Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -86,15 +86,15 @@ harness = false

[dependencies]
# Python Bindings (optional)
pyo3 = { version = "0.24.1", features = ["extension-module"], optional = true }
pyo3 = { version = "0.27.2", features = ["extension-module"], optional = true }
Copy link

Copilot AI Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pyo3 dependency is being updated from 0.24.1 to 0.27.2, which is a major version jump (two minor versions). According to the changelog, version 0.27.0 introduced several breaking changes including:

  1. Dropped support for PyPy 3.9 and 3.10
  2. Introduced new trait bounds and API changes
  3. Changes to type checking and casting behavior

Since this is an optional dependency (used for Python bindings), you should verify that:

  1. The Python bindings code still compiles with the new API
  2. Any PyPy users are aware of the dropped support
  3. The Python module still works as expected after the upgrade

The changelog also mentions fixes for crashes with dict subclassing on PyPy/GraalPy, which are positive changes.

Copilot uses AI. Check for mistakes.

# Serialization
serde = { version = "1.0", features = ["derive"] }
serde_json = "1.0"
serde_bytes = "0.11"

# Binary serialization (faster than JSON for embeddings)
bincode = "1.3"
bincode = "3.0"
Copy link

Copilot AI Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bincode dependency is being updated from version 1.3 to 3.0, which is a major version jump that introduces breaking changes. This crate is used extensively throughout the codebase for serialization and deserialization operations (particularly in storage/sync_worker.rs). Major version updates in bincode typically change the serialization format, which can break compatibility with existing serialized data. Before merging this PR, you should:

  1. Review the bincode 3.0 changelog for breaking changes
  2. Verify that existing serialized data (WAL entries, stored MemoryEntry objects) can still be deserialized
  3. Consider implementing a migration strategy if the serialization format is incompatible
  4. Test the upgrade with existing data to ensure backward compatibility
Suggested change
bincode = "3.0"
bincode = "1.3"

Copilot uses AI. Check for mistakes.

# MessagePack serialization (compact binary format)
rmp-serde = "1.3"
Expand All @@ -103,7 +103,7 @@ rmp-serde = "1.3"
qdrant-client = "1.10"

# Full-text Search (Tantivy BM25)
tantivy = "0.22"
tantivy = "0.25"

# Embedded key-value store (pure Rust)
sled = "0.34"
Expand All @@ -112,11 +112,11 @@ sled = "0.34"
tokio = { version = "1", features = ["full"] }

# HTTP Client (for Qdrant health checks)
reqwest = { version = "0.12", features = ["json"] }
reqwest = { version = "0.13", features = ["json"] }
Copy link

Copilot AI Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reqwest dependency is being updated from 0.12 to 0.13. According to the changelog in the PR description, version 0.13.0 introduced several breaking changes:

  1. rustls is now the default TLS backend instead of native-tls
  2. rustls crypto provider defaults to aws-lc instead of ring
  3. query and form are now crate features, disabled by default
  4. Long-deprecated methods have been removed

Since this codebase uses reqwest for HTTP client operations (embedding API calls, Qdrant health checks), you should verify that:

  1. The TLS backend change doesn't affect connectivity
  2. Any query/form usage is covered by enabling the appropriate features if needed
  3. No deprecated methods are being used that were removed in 0.13.0
Suggested change
reqwest = { version = "0.13", features = ["json"] }
reqwest = { version = "0.13", features = ["json", "query", "form"] }

Copilot uses AI. Check for mistakes.

# Error Handling
anyhow = "1.0"
thiserror = "1.0"
thiserror = "2.0"

# Async traits
async-trait = "0.1"
Expand All @@ -143,7 +143,7 @@ crc32fast = "1.4"
rayon = "1.10"

# Concurrent data structures
dashmap = "5.5"
dashmap = "6.1"

# CPU detection for optimal shard count
num_cpus = "1.16"
Expand All @@ -152,19 +152,19 @@ num_cpus = "1.16"
crossbeam-utils = "0.8"

# Directories (for default paths)
dirs = "5"
dirs = "6"

# ONNX Runtime for local embeddings (BGE-M3)
ort = { version = "2.0.0-rc.10", optional = true }

# HuggingFace tokenizers
tokenizers = { version = "0.19", optional = true }
tokenizers = { version = "0.22", optional = true }

# NDArray for tensor operations
ndarray = { version = "0.16", optional = true }
ndarray = { version = "0.17", optional = true }

# LZ4 compression (optional, for dual-layer memory)
lz4_flex = { version = "0.11", optional = true }
lz4_flex = { version = "0.12", optional = true }

# ============================================================================
# DEV DEPENDENCIES
Expand All @@ -174,7 +174,7 @@ lz4_flex = { version = "0.11", optional = true }
tokio-test = "0.4"
tempfile = "3.10"
pretty_assertions = "1.4"
criterion = { version = "0.5", features = ["async_tokio"] }
criterion = { version = "0.8", features = ["async_tokio"] }
proptest = "1.4"

# ============================================================================
Expand Down
Loading