Make compilebuildtool build all tools by default#293
Closed
ericholscher wants to merge 1 commit intomainfrom
Closed
Make compilebuildtool build all tools by default#293ericholscher wants to merge 1 commit intomainfrom
ericholscher wants to merge 1 commit intomainfrom
Conversation
Member
|
Preliminar review, looks good. |
Member
|
Seems you started from an old commit since there are a few commits that are mine 😄 |
When called without arguments, compiles all tools and all versions. When called with just a tool, compiles all versions of that tool. The previous behavior of specifying both tool and version still works. Ref: readthedocs/readthedocs.org#11235
ericholscher
force-pushed
the
fix/compilebuildtool-default-all-11235
branch
from
b24b148 to
e750674
Compare
Member
Author
|
I think I ended up copying them from S3 with rclone, which is probably a better approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toolandversionarguments optional ininv docker.compilebuildtoolinv docker.compilebuildtool python), compiles all versions of that tool[1/48] Compiling python 2.7...) for visibility during long runsPer @humitos in readthedocs/readthedocs.org#11235: the command should build everything by default.
Test plan
inv docker.compilebuildtool(no args) compiles all tools and versionsinv docker.compilebuildtool pythoncompiles all Python versionsinv docker.compilebuildtool python 3.12compiles just Python 3.12 (existing behavior)inv docker.compilebuildtool --version 3.12without tool prints error messageMade by AI