fix(mdxish-editor): embed serialization missing data#1376
Draft
fix(mdxish-editor): embed serialization missing data#1376
Conversation
eaglethrost
reviewed
Mar 20, 2026
eaglethrost
reviewed
Mar 20, 2026
eaglethrost
reviewed
Mar 20, 2026
eaglethrost
reviewed
Mar 20, 2026
| attributes: parseAttributes(attrString), | ||
| children: [], | ||
| position: paragraph.position, | ||
| data: { raw: value }, |
Contributor
There was a problem hiding this comment.
What's data raw value for?
Contributor
Author
There was a problem hiding this comment.
I added it because I thought we need to preserve the magic block format. Thanks for pointing this out!
Just removed it
eaglethrost
reviewed
Mar 20, 2026
eaglethrost
previously requested changes
Mar 20, 2026
Contributor
eaglethrost
left a comment
There was a problem hiding this comment.
Flow looks good, requested some changes
Co-authored-by: Dimas Putra Anugerah <63914983+eaglethrost@users.noreply.github.com>
Contributor
|
Nice looks good, tested with the readme side PR and it seems to have fixed the serialization issue! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Missing Embed attributes
Added missing Embed attributes to serialization process
Multi line Embed serialization bug
Problem
Multi-line
<Embed />JSX content failed to deserialize in theMdxishEditor, throwing:RangeError: Invalid content for node doc: <>Root Cause
When JSX spans multiple lines like:
CommonMark doesn't recognize it as an HTML block (because <Embed is incomplete on line 1). Instead, it
wraps it in a paragraph > html structure, which downstream processors couldn't handle correctly.
Solution
Created a new AST-level plugin
mdxish-self-closing-blocks.tsthat:mdxJsxFlowElementnode🧬 QA & Testing