refactor(uvm): split Update into WCOW and LCOW specific files#6
Draft
Copilot wants to merge 4 commits intofeat/lcow-shimfrom
Draft
refactor(uvm): split Update into WCOW and LCOW specific files#6Copilot wants to merge 4 commits intofeat/lcow-shimfrom
Copilot wants to merge 4 commits intofeat/lcow-shimfrom
Conversation
In this commit, we are adding the initial draft of `containerd-shim-lcow-v1`. This shim is used for running Linux Containers on Windows. As part of this commit, we are adding the following- - The main entrypoint and supporting logic to start + serve the shim server. - The stubs for Task Service and Shimdiag service. - The implementation for `Sandbox` service. - The implementation for `VM Controller` which manages the VM lifecycle and operations. Signed-off-by: Harsh Rawat <harshrawat@microsoft.com>
Co-authored-by: rawahars <65640262+rawahars@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor Update method for WCOW and LCOW separation
refactor(uvm): split Update into WCOW and LCOW specific files
Mar 15, 2026
4451f3c to
8c846bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UtilityVM.Updatemixed WCOW and LCOW resource handling in a single method, making it harder to maintain and extend independently per container type.Changes
update_uvm_wcow.go— new file withupdateWCOW, handling*specs.WindowsResources(memory limit, CPU maximum/shares)update_uvm_lcow.go— new file withupdateLCOW, handling*specs.LinuxResources(memory limit, CPU quota/shares) and*ctrdtaskapi.PolicyFragmentupdate_uvm.go— replaced monolithic implementation with a thin OS dispatcher:This mirrors the existing
create_wcow.go/create_lcow.gopattern and makes the separation ready for future compile-time build tag gating if WCOW-only or LCOW-only binaries are needed.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.