Skip to content

Conversation

@nbuchwitz
Copy link
Contributor

Move the default mass-storage-gadget64 directory path from a hardcoded value in main.c to a build-time configurable variable in the Makefile. On Windows, this defaults to the standard installation path used by the Windows installer. On Unix systems, the behavior remains unchanged.

This allows rpiboot to be invoked without the -d parameter on Windows.

Fixes: #342

@nbuchwitz nbuchwitz force-pushed the feature/msg-path-windows branch from e4aa5e5 to c0846a3 Compare December 10, 2025 15:17
@timg236
Copy link
Collaborator

timg236 commented Dec 10, 2025

This looks like a useful change.

N.B. Now that mass-storage-gadget64 is working on PiZero2, CM3* I'm planning to make this the default instead of the VPU firmware implemenation. I think the outlier is possibly PiZero.

Move the default mass-storage-gadget64 directory path from a hardcoded
value in main.c to a build-time configurable variable in the Makefile.
On Windows, this defaults to the standard installation path used by the
Windows installer. On Unix systems, the behavior remains unchanged.

This allows rpiboot to be invoked without the -d parameter on Windows.

Fixes: raspberrypi#342

Signed-off-by: Nicolai Buchwitz <[email protected]>
@nbuchwitz nbuchwitz force-pushed the feature/msg-path-windows branch from c0846a3 to 225649e Compare December 11, 2025 07:55
@nbuchwitz
Copy link
Contributor Author

nbuchwitz commented Dec 11, 2025

This looks like a useful change.

N.B. Now that mass-storage-gadget64 is working on PiZero2, CM3* I'm planning to make this the default instead of the VPU firmware implemenation. I think the outlier is possibly PiZero.

That's good to hear. We've seen an increasing number of issues raised by our users, which have overlooked the bat files on Windows and are trying to use rpiboot.exe as before. So I really hope that this will make it a bit better for all the Windows.

btw: Wouldn't it make sense to make a new "official" release on the github project? Last release was when CM4S was introduced.

@timg236 timg236 merged commit 57c61e9 into raspberrypi:master Dec 11, 2025
1 check passed
@timg236
Copy link
Collaborator

timg236 commented Dec 11, 2025

This looks like a useful change.
N.B. Now that mass-storage-gadget64 is working on PiZero2, CM3* I'm planning to make this the default instead of the VPU firmware implemenation. I think the outlier is possibly PiZero.

That's good to hear. We've seen an increasing number of issues raised by our users, which have overlooked the bat files on Windows and are trying to use rpiboot.exe as before. So I really hope that this will make it a bit better for all the Windows.

btw: Wouldn't it make sense to make a new "official" release on the github project? Last release was when CM4S was introduced.

Yes. Actually, I think we can drop the .exe from the Git repo and just attach it to a release to make the git shallow clone a bit quicker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make default directory for 2711/2712 OS aware (Windows)

2 participants