-
Notifications
You must be signed in to change notification settings - Fork 157
add documentation for reboot --diagnostic option #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Please do not submit against |
4206d15 to
89e765f
Compare
|
Please do not submit against |
will-v-pi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
|
Does the README.md also need to be updated @will-v-pi ? |
|
It looks like the reboot command is missing from the README entirely, and it's not being caught by the script because it's defined slightly differently to the others |
Ooops 😉 |
What is "the script" if I may ask? :) I only noticed that the --diagnostic option was missing documentation because my own set of scripts broke due to the missing docs:
The scripts parse the --help output and turn it into a man page using pandoc. help2man is unfortunately not able to parse the specific format of picotool --help. |
See https://github.com/raspberrypi/picotool/blob/master/.github/workflows/check_help_text.yml and https://github.com/raspberrypi/picotool/blob/master/gen_help_txt.sh |
Ah, good to know that processing main.cpp with regexes is actually not as evil as I thought it would be. I'll add the fact that you are doing the same thing in |
No description provided.