Skip to content

Conversation

@josch
Copy link
Contributor

@josch josch commented Sep 4, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Sep 4, 2025

Please do not submit against master, use develop instead

@github-actions
Copy link

github-actions bot commented Sep 4, 2025

Please do not submit against master, use develop instead

@josch josch changed the base branch from master to develop September 4, 2025 16:03
Copy link
Contributor

@will-v-pi will-v-pi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@will-v-pi will-v-pi merged commit 4342402 into raspberrypi:develop Sep 12, 2025
38 checks passed
@lurch
Copy link
Contributor

lurch commented Sep 15, 2025

Does the README.md also need to be updated @will-v-pi ?

@will-v-pi
Copy link
Contributor

It looks like the reboot command is missing from the README entirely, and it's not being caught by the script because it's defined slightly differently to the others

@lurch
Copy link
Contributor

lurch commented Sep 15, 2025

It looks like the reboot command is missing from the README entirely, and it's not being caught by the script because it's defined slightly differently to the others

Ooops 😉

@josch
Copy link
Contributor Author

josch commented Sep 15, 2025

It looks like the reboot command is missing from the README entirely, and it's not being caught by the script because it's defined slightly differently to the others

What is "the script" if I may ask? :)

I only noticed that the --diagnostic option was missing documentation because my own set of scripts broke due to the missing docs:

The scripts parse the --help output and turn it into a man page using pandoc. help2man is unfortunately not able to parse the specific format of picotool --help.

@lurch
Copy link
Contributor

lurch commented Sep 15, 2025

@josch
Copy link
Contributor Author

josch commented Sep 15, 2025

https://github.com/raspberrypi/picotool/blob/master/gen_help_txt.sh

Ah, good to know that processing main.cpp with regexes is actually not as evil as I thought it would be. I'll add the fact that you are doing the same thing in gen_help_txt.sh to my scripts, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants