Merged
Conversation
@kilograham A few proposed changes to the readme: - Remove some early access copy - Call out which examples are RP235x only - Fix link the HSTX example Could you review the first paragraph of build instructions too?
Contributor
|
@will-v-pi Would this PR be a good opportunity to change the RISC-V compiler link, as you suggested in #516 (comment) ? |
Contributor
Might want to double check with @Wren6991 about that? |
This was referenced Sep 10, 2024
nathan-contino
approved these changes
Dec 5, 2024
Contributor
nathan-contino
left a comment
nathan-contino
left a comment
There was a problem hiding this comment.
LGTM from a documentation/copy perspective, with one suggestion. Can we merge this in?
Contributor
|
Apparently this has conflicts with the current README.md 👇 |
Co-authored-by: nate contino <[email protected]>
kilograham
previously approved these changes
Dec 5, 2024
lurch
reviewed
Dec 5, 2024
peterharperuk
previously approved these changes
Feb 6, 2025
lurch
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@kilograham A few proposed changes to the readme:
Could you review the first paragraph of build instructions too?