Use hostname when sigar_fqdn_get returns an IP address #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigar_fqdn_get() returns an IP address when the system hostname is not a fully qualified domain name. Since we want the hostname in this case, check if the returned value is an IP address and fall back to sigar_net_info_get() to retrieve the actual hostname. Also increase fqdn buffer size from SIGAR_MAXDOMAINNAMELEN (256) to SIGAR_FQDN_LEN (512) to properly accommodate FQDNs.
This was referenced Jan 11, 2026
adfoster-r7
approved these changes
Jan 15, 2026
adfoster-r7
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sigar_fqdn_get()returns an IP address when the system hostname is not a fully qualified domain name. Since we want the hostname in this case, check if the returned value is an IP address and fall back tosigar_net_info_get()to retrieve the actual hostname.Also increase fqdn buffer size from
SIGAR_MAXDOMAINNAMELEN(256) toSIGAR_FQDN_LEN(512) to properly accommodate FQDNs.Fixes #239.