Fix the flakey UDP channel tests #20729
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroSteiner
force-pushed
the
fix/issue/socket-channels-udp-flakies
branch
3 times, most recently
from
61489f0 to
d733ed8
Compare
zeroSteiner
force-pushed
the
fix/issue/socket-channels-udp-flakies
branch
from
d733ed8 to
2bbcd7d
Compare
smcintyre-r7
added
the
payload-testing-branch
zeroSteiner
force-pushed
the
fix/issue/socket-channels-udp-flakies
branch
2 times, most recently
from
29cdc8c to
da91209
Compare
zeroSteiner
changed the title
zeroSteiner
force-pushed
the
fix/issue/socket-channels-udp-flakies
branch
8 times, most recently
from
b25ab8c to
98a21b0
Compare
Contributor
Author
|
The PHP setup task for 7.4 and 8.3 on macos 13 are failing with this output when run with PHP Setup Error with macos-13 Runnerhttps://github.com/rapid7/metasploit-framework/actions/runs/19974896801/job/57288717145?pr=20729 Detailshttps://github.com/rapid7/metasploit-framework/actions/runs/19976548277/job/57294121174?pr=20729 This occurred in the Setup Ruby task: |
zeroSteiner
force-pushed
the
fix/issue/socket-channels-udp-flakies
branch
3 times, most recently
from
4f10407 to
eb001b8
Compare
zeroSteiner
force-pushed
the
fix/issue/socket-channels-udp-flakies
branch
from
f1feb91 to
7c57c88
Compare
1 task
zeroSteiner
force-pushed
the
fix/issue/socket-channels-udp-flakies
branch
2 times, most recently
from
a26179e to
69492b9
Compare
zeroSteiner
force-pushed
the
fix/issue/socket-channels-udp-flakies
branch
2 times, most recently
from
673fdff to
83d27b2
Compare
adfoster-r7
reviewed
Jan 13, 2026
| } | ||
| ], | ||
| module_tests: [ | ||
| { |
Contributor
There was a problem hiding this comment.
iirc at the minute there's a 1 to 1 mapping of the post/test modules to the automated meterpreter tests so that we can ensure consistency in the payload behaviors - is there any context on why we need to delete the test here? 👀
Contributor
Author
There was a problem hiding this comment.
These tests are all skipped because PHP doesn't support services, railgun or the registry API. The command exec tests don't run anymore because PHP 5.3 isn't a runner.
adfoster-r7
reviewed
Jan 13, 2026
zeroSteiner
force-pushed
the
fix/issue/socket-channels-udp-flakies
branch
2 times, most recently
from
3233349 to
c7212c1
Compare
adfoster-r7
reviewed
Jan 15, 2026
| - { name: java, runtime_version: 21 } | ||
|
|
||
| # PHP | ||
| - { name: php, runtime_version: 5.3 } |
Contributor
There was a problem hiding this comment.
Instead of dropping 5.3 support entirely from the test suite; what are your thoughts on just providing a different UX for the broken behavior? i.e. provide graceful degradation for just the failing UDP behavior that is it problematic, that way in the future we can know if the payload breaks entirely versus a subset of the behavior being unsupported
Contributor
There was a problem hiding this comment.
It also looks like this PR description suggests the functionality should pass: rapid7/metasploit-payloads#787
This resolves those issues so the socket tests that are intended to pass do pass with both PHP v8.4 on Linux and PHP v5.3 on Winows.
php 5.3 windows-2022:
Failures:
1) Meterpreter php stageless php/meterpreter_reverse_tcp windows post/test/socket_channels windows/php meterpreter successfully opens a session for the "php/meterpreter_reverse_tcp" payload and passes the "post/test/socket_channels" tests
Failure/Error: expect(test_line).to_not include('FAILED', '[-] FAILED', '[-] Exception', '[-] '), "Unexpected error: #{test_line}"
Unexpected error: [-] FAILED: [UDP] Receives data from the peer
c7212c1 to
afc26c4
Compare
zeroSteiner
force-pushed
the
fix/issue/socket-channels-udp-flakies
branch
from
afc26c4 to
b47e3d9
Compare
Contributor
|
Superseded by #20868 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix most of the Meterpreter acceptance tests. This whole things was a giant exercise in CI whack a mole where almost all of the issues were related to the runners and not actually in Meterpreter.
Requires rapid7/metasploit-payloads#787 for the one issue that was due to Meterpreter.