Skip to content

Conversation

@joshdimanteto
Copy link

@joshdimanteto joshdimanteto commented Jan 9, 2026

This PR will close #522

Description

Refactor the SQL models to use pydantic
Generate the models use the SQL received from the icat server
Fix the models for the post and patch requests

Testing Instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check GitHub Actions build
  • If icatdb Generator Script Consistency Test CI job fails, is this because of a deliberate change made to the script to change generated data (which isn't actually a problem) or is here an underlying issue with the changes made?
  • Review changes to test coverage
  • Does this change mean a new patch, minor or major version should be made? If so, does one of the commit messages feature fix:, feat: or BREAKING CHANGE: so a release is automatically made via GitHub Actions upon merge?
  • {more steps here}

Agile Board Tracking

Closes #522

@joshdimanteto joshdimanteto changed the title Refactor dg api model to pydantic 522 Refactor dg api model to pydantic #522 Jan 9, 2026
@joshdimanteto joshdimanteto force-pushed the refactor-dg-api-model-to-pydantic-522 branch from 1433a3d to 3b7621f Compare January 9, 2026 20:13
@joshdimanteto joshdimanteto force-pushed the refactor-dg-api-model-to-pydantic-522 branch from 3b7621f to f0b4bf6 Compare January 9, 2026 20:32
- add TODO for issue found with post and patch requesr #525
@joshdimanteto joshdimanteto force-pushed the refactor-dg-api-model-to-pydantic-522 branch from fd2f29c to cc387dc Compare January 16, 2026 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants