Fix application of SOLID_QUEUE_SUPERVISOR_MODE environment variable
#709
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The readme states that
SOLID_QUEUE_SUPERVISOR_MODEenvironment variable can be used to control supervisor mode. However, this isn't the case currently. When I run:Solid Queue is still started in fork mode.
This is because
Cliclass sets the default value for--modeoption tofork:solid_queue/lib/solid_queue/cli.rb
Line 11 in 552f7d0
so when
Configurationis instantiated:solid_queue/lib/solid_queue/configuration.rb
Lines 34 to 35 in 552f7d0
optionswill always contain{ mode: "fork" }, sodefault_options, which reads theSOLID_QUEUE_SUPERVISOR_MODEenv variable, never applies:solid_queue/lib/solid_queue/configuration.rb
Lines 93 to 95 in 552f7d0
This PR removes the default value from
Cliclass so thatdefault_optionscan apply.I didn't add any tests, but let me know if (and where) I should.