-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/api v1 #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Feature/api v1 #96
Conversation
📊 Test Coverage Report✅ Total Coverage: 90.2% 📋 View Detailed Report |
char2cs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Estaría bueno juntarnos a hablar varios puntos de acá @AgustinGil21. El diseño está buenísimo, pero creo que algunas cosas son challengeables y mejorables.
Si queres, propongamos un espacio para verlo durante la semana/o el finde, cuando puedas.
Un laburazo Agus, quedan ajustes chicos nada mas.
📊 Test Coverage Report✅ Total Coverage: 90.2% 📋 View Detailed Report |
📊 Test Coverage Report✅ Total Coverage: 90.2% 📋 View Detailed Report |
📊 Test Coverage Report✅ Total Coverage: 90.2% 📋 View Detailed Report |
Lucacux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. The PR introduces the API v1 in a well-structured way, with clear separation between handlers, use cases, and routing. Test coverage is solid and the inclusion of documentation is a positive addition.
Overall a solid code structure. I'll give it a pass from my point of view 👍 .
Description
This PR improves the API surface by adding and hardening core features. It introduces refined arrow usecases, stable HTTP handlers, organized route registration, Swagger UI integration, and more robust API bootstrapping and middleware setup. These changes make the REST API more stable, consistent, and discoverable.
Type of Change
Related Issues
API / Websocket / Scaffolding #85
Changes Made
/api/v1routes and fixed missing handler bindings.Breaking Changes
Checklist
./docs/foldermake test)make test-coverage)make lint)make security)