Feature/Optional Database Caching #90
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Test Coverage Report✅ Total Coverage: 90.4% 📋 View Detailed Report |
char2cs
requested changes
Dec 17, 2025
Member
char2cs
left a comment
char2cs
left a comment
There was a problem hiding this comment.
Sacando los comentarios, buena implementación y usás bien los conceptos de Go. Trataría de reducir la cantidad de archivos y aplicar mejor algunos conceptos del lenguaje, pero le estás agarrando la mano.
… to return an unmarshal error but it checked for if there was none. Updated logic to assert expected behaviour. Checking for if: 1. found == true then error == nil else 2. found == false then error != nil && error contains "unmarshal"
�[0;32mCode formatted!�[0m (mala mia chicos jajajaj)
…alues in internal/core/database/cache/config.go
…sitory. Fixed tests. Removed unused field Context from builder.go.
…go to satisfy new RepositoryInterface
Valentin-Vi
force-pushed
the
feature/cache-abstraction-layer
branch
from
9bba170 to
cf9df25
Compare
…go up to 94.4%. Fixed missing error handling and implemented use of Watcher.Warn for configuration errors and cache write failure
…tory.go constructor.
📊 Test Coverage Report✅ Total Coverage: 90.9% 📋 View Detailed Report |
📊 Test Coverage Report✅ Total Coverage: 90.9% 📋 View Detailed Report |
char2cs
requested changes
Jan 6, 2026
| return nil, err | ||
| } | ||
|
|
||
| for _, entity := range result { |
Member
There was a problem hiding this comment.
Aca valen guarda, estamos reimplementando la funcion del repositorio para guardar.
La capa de cache deberia ser un wrapper por sobre el repositorio original:
v, found := cr.cache.GetById(key) // Primero buscamos en cache
if found {
data, ok := v.([]byte)
if !ok {
return nil, cacheerr.ErrInvalidCacheValue
}
var result []*T
err := json.Unmarshal(data, &result)
if err != nil {
return nil, err
}
return result, nil // Si esta devolvemos eso
}
entity, err := baseRepository.GetById() // Si no fallbackeamos al repositorio original
if err != nil {
return err
}
go cr.cache.AsyncSet(entity) // Asincronicamente hidratamos el cache
return entity // Y devolvemos la respuesta…r a method/function to retrieve keys from a (signature .
📊 Test Coverage Report✅ Total Coverage: 90.8% 📋 View Detailed Report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements an optional in-memory caching layer for the Core database module using the builder pattern. The cache wraps the base database interface with a cache layer (decorator pattern) to improve read performance and reduce database I/O. This is step 1 of the broader persistence initiative.
Type of Change
Related Issues
Closes #59
Changes Made
Cacheinterface withGet,Set,Delete, andFlushmethods supporting TTLGoCacheusinggithub.com/patrickmn/go-cachelibrary (as specified in issue Core / Database / Cache Abstraction Layer #59)RepositoryCachedecorator that wraps base repository with transparent cachingDatabaseBuilderpattern with optionalWithCache()method for flexible compositioncache.enabled,cache.default_ttl,cache.cleanup_interval)default.yaml(disabled by default)CacheConfigNewDatabase()function still works without changesgithub.com/patrickmn/go-cachedependency (v2.1.0+incompatible)New Files
internal/core/database/cache/interface.go- Cache interface definitioninternal/core/database/cache/config.go- Cache configuration struct and defaultsinternal/core/database/cache/memory_cache.go- Alternative in-memory cache implementation (used in tests, not in production code)internal/core/database/cache/gocache.go- go-cache implementation usinggithub.com/patrickmn/go-cacheinternal/core/database/cache/repository_cache.go- Repository decorator with cachinginternal/core/database/cache/config_helper.go- YAML config to CacheConfig converterinternal/core/database/builder.go- DatabaseBuilder pattern implementationinternal/core/database/cache/cache_test.go- Cache interface testsinternal/core/database/cache/repository_cache_test.go- Repository cache testsinternal/core/database/builder_test.go- Builder pattern testsinternal/core/database/integration_test.go- Integration testsModified Files
internal/core/config/config.go- Added Cache struct and GetCache() functioninternal/core/config/default.yaml- Added cache configuration sectiongo.mod- Addedgithub.com/patrickmn/go-cachedependencyBreaking Changes
Migration Guide
No breaking changes. The cache is optional and disabled by default. Existing code using
NewDatabase()continues to work without modification. This is a purely additive feature.To enable caching, use the new builder pattern:
Or enable via configuration file:
Checklist
./docs/foldermake test)make test-coverage)make lint)make security)Screenshots/Logs (if applicable)
Test Coverage Summary
Key Features
go-cachelibrary which is thread-safe by designgithub.com/patrickmn/go-cacheas specified in issue Core / Database / Cache Abstraction Layer #59