Skip to content

Commit 4a5134b

Browse files
committed
chore(ci): update PR coverage requirement from 90% to 80%
This commit modifies the CI workflow to lower the required pull request coverage from 90% to 80%. Corresponding updates are made in the documentation to reflect this change, ensuring consistency across the project guidelines.
1 parent 6a00377 commit 4a5134b

File tree

5 files changed

+14
-14
lines changed

5 files changed

+14
-14
lines changed

.github/workflows/ci.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -228,12 +228,12 @@ jobs:
228228
PR_COVERAGE=$((COVERED_LINES * 100 / TOTAL_LINES))
229229
echo "PR coverage: ${PR_COVERAGE}%"
230230
231-
if [ $PR_COVERAGE -lt 90 ]; then
232-
echo "❌ PR coverage ${PR_COVERAGE}% is below required 90%"
231+
if [ $PR_COVERAGE -lt 80 ]; then
232+
echo "❌ PR coverage ${PR_COVERAGE}% is below required 80%"
233233
exit 1
234234
fi
235235
236-
echo "✅ PR coverage ${PR_COVERAGE}% meets requirement (≥90%)"
236+
echo "✅ PR coverage ${PR_COVERAGE}% meets requirement (≥80%)"
237237
else
238238
echo "ℹ️ No coverage data to calculate for PR changes"
239239
fi
@@ -312,7 +312,7 @@ jobs:
312312
echo "- ✅ Branch follows the defined branching model"
313313
echo "- ✅ Code compiles successfully"
314314
echo "- ✅ Overall test coverage ≥ 80%"
315-
echo "- ✅ PR coverage ≥ 90%"
315+
echo "- ✅ PR coverage ≥ 80%"
316316
echo "- ✅ Code quality and security checks passed"
317317
echo ""
318318
echo "🎉 This PR is ready for review!"

docs/branching-model.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ Quiver follows a **Git Flow-inspired branching model** with strict rules for pul
2121
1. **Protected Branches**: `master` and `develop` are protected branches
2222
2. **PR-Only Integration**: All changes must go through pull requests
2323
3. **Comprehensive CI**: Every PR runs automated checks
24-
4. **Quality Gates**: Minimum 80% overall coverage, 90% PR coverage
24+
4. **Quality Gates**: Minimum 80% overall coverage, 80% PR coverage
2525

2626
## Branch Types
2727

@@ -123,7 +123,7 @@ The CI pipeline runs **only on pull requests** and consists of four main stages:
123123

124124
**Coverage Requirements**:
125125
- **Overall Project Coverage**: ≥ 80%
126-
- **PR Coverage**: ≥ 90% (for changed files)
126+
- **PR Coverage**: ≥ 80% (for changed files)
127127

128128
**Process**:
129129
1. Run all tests with race detection
@@ -152,7 +152,7 @@ All stages must pass for the PR to be considered valid:
152152
- ✅ Branch follows the defined branching model
153153
- ✅ Code compiles successfully
154154
- ✅ Overall test coverage ≥ 80%
155-
- ✅ PR coverage ≥ 90%
155+
- ✅ PR coverage ≥ 80%
156156
- ✅ Code quality and security checks passed
157157
158158
🎉 This PR is ready for review!
@@ -296,7 +296,7 @@ make pr-checks
296296
2. Remove unused/dead code
297297
3. Check `coverage.html` report for specific areas
298298

299-
**Problem**: `❌ PR coverage 85% is below required 90%`
299+
**Problem**: `❌ PR coverage 75% is below required 80%`
300300

301301
**Solutions**:
302302
1. Add tests for all new/changed code

docs/contributing-guide.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ type ArrowsInterface interface {
252252

253253
### Coverage Requirements
254254
- **Overall Project Coverage**: ≥ 80%
255-
- **Pull Request Coverage**: ≥ 90%
255+
- **Pull Request Coverage**: ≥ 80%
256256

257257
### Test Structure
258258
```

docs/development-setup.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ make test-docker
235235
### Coverage Requirements
236236

237237
- **Overall Project Coverage**: ≥ 80%
238-
- **Pull Request Coverage**: ≥ 90%
238+
- **Pull Request Coverage**: ≥ 80%
239239

240240
### Test Structure
241241

docs/git-workflow.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ Quiver follows a **Git Flow-inspired branching model** with strict rules for pul
1111
1. **Protected Branches**: `master` and `develop` are protected branches
1212
2. **PR-Only Integration**: All changes must go through pull requests
1313
3. **Comprehensive CI**: Every PR runs automated checks
14-
4. **Quality Gates**: Minimum 80% overall coverage, 90% PR coverage
14+
4. **Quality Gates**: Minimum 80% overall coverage, 80% PR coverage
1515

1616
## Branch Types
1717

@@ -113,7 +113,7 @@ The CI pipeline runs **only on pull requests** and consists of four main stages:
113113

114114
**Coverage Requirements**:
115115
- **Overall Project Coverage**: ≥ 80%
116-
- **PR Coverage**: ≥ 90% (for changed files)
116+
- **PR Coverage**: ≥ 80% (for changed files)
117117

118118
**Process**:
119119
1. Run all tests with race detection
@@ -142,7 +142,7 @@ All stages must pass for the PR to be considered valid:
142142
- ✅ Branch follows the defined branching model
143143
- ✅ Code compiles successfully
144144
- ✅ Overall test coverage ≥ 80%
145-
- ✅ PR coverage ≥ 90%
145+
- ✅ PR coverage ≥ 80%
146146
- ✅ Code quality and security checks passed
147147
148148
🎉 This PR is ready for review!
@@ -286,7 +286,7 @@ make pr-checks
286286
2. Remove unused/dead code
287287
3. Check `coverage.html` report for specific areas
288288

289-
**Problem**: `❌ PR coverage 85% is below required 90%`
289+
**Problem**: `❌ PR coverage 75% is below required 80%`
290290

291291
**Solutions**:
292292
1. Add tests for all new/changed code

0 commit comments

Comments
 (0)