add more options #1
Conversation
change package name back to original package for PR
change package name back to original
filipenevola
left a comment
filipenevola
left a comment
There was a problem hiding this comment.
A few questions and recommendations.
Also a required change.
See the comments.
| To: to, | ||
| Subject: subject, | ||
| HtmlBody: content, | ||
| To: options.to, |
There was a problem hiding this comment.
What is the behavior of postmark if the optional fields are undefined?
| Headers: [ | ||
| { | ||
| Name: "Message-ID", | ||
| Value: options.messageId |
There was a problem hiding this comment.
What is the behavior of postmark if these fields are provided but undefined?
|
|
||
| export const sendEmail = async ({ to, subject, content, from: fromParam }) => { | ||
| const from = fromParam || settings.from; | ||
| export const sendEmail = async (options) => { |
There was a problem hiding this comment.
a function call without any arg would break in the next line.
it would be better to have async (options = {}) to avoid undefined errors destructing args.
| const overrideOptions = Email.overrideOptionsBeforeSend | ||
| ? Email.overrideOptionsBeforeSend(options) | ||
| : {}; | ||
| const { to, html} = options; |
There was a problem hiding this comment.
overrideOptionsBeforeSend is an email from the Email package of Meteor so we should continue supporting it.
It's going to be called outside the user flow here in this code so it's necessary.
2 participants
No description provided.