plat-qcom: lemans: enable QFPROM fuse provisioning support#6
plat-qcom: lemans: enable QFPROM fuse provisioning support#6zelvam95 wants to merge 4 commits intoqualcomm-linux:qcom-nextfrom
Conversation
|
Looks good to me. |
zelvam95
force-pushed
the
feature/plat-qcom-lemans-fuseprov-enablement
branch
2 times, most recently
from
b55ab01 to
4cb7539
Compare
| #define QFPROM_CLOCK_DIVIDE 0x7 | ||
| #endif | ||
|
|
||
| #if defined(PLATFORM_FLAVOR_kodiak) |
There was a problem hiding this comment.
I don't see this #ifdef as a scalable approach overall in the clock driver. I think you should rather absract the generic clock driver to deal with whatever target specific clocks are supported via a generic header file. Then you can return not supported error if a clock is not defined for a particular target.
There was a problem hiding this comment.
yeah, this is part of the new PAS https://github.com/OP-TEE/optee_os/pull/7721/commits . I think we should drop the PAS version we have in the staging tree and use this one instead - rebase is going to be messy
There was a problem hiding this comment.
Okay let me try to rebase now with your latest patch-set. It will then be easier for @zelvam95
zelvam95
force-pushed
the
feature/plat-qcom-lemans-fuseprov-enablement
branch
from
4cb7539 to
745c512
Compare
@zelvam95 let me do the qcom-next rebase now to tip so that's easier for your refactoring work |
|
@zelvam95 please rebase both of your PRs to tip of qcom-next. It's already rebased to include latest PAS PR from Jorge. |
|
I'll follow up with the review as soon as you rebase @zelvam95 - seems we are close now |
|
ah this is to be abandoned I guess |
I will rebase this on Tip. Will make this work. Will raise the patch tonight/weekend :) |
zelvam95
force-pushed
the
feature/plat-qcom-lemans-fuseprov-enablement
branch
from
745c512 to
8038358
Compare
zelvam95
force-pushed
the
feature/plat-qcom-lemans-fuseprov-enablement
branch
2 times, most recently
from
564f51c to
414eb04
Compare
|
Can you please review the latest patch? I have refactored it based on the tip now and have pushed it. Can you please review and let me know if any comments on this? |
|
um, I am going to extract the PAS clocks from that file into its own file. it is too messy otherwise. |
PAS clock configuration is conditionally compiled and platform-specific; keeping it in the same file as the core clock setup adds unnecessary coupling and complicates maintenance. No functional change. Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez@oss.qualcomm.com>
zelvam95
force-pushed
the
feature/plat-qcom-lemans-fuseprov-enablement
branch
2 times, most recently
from
aac148d to
b4bf594
Compare
Refactor QFPROM-specific clock configuration into a generic clock rate setting API. This allows QFPROM driver to directly manage its clocks using the generic clock rate API instead of going through the clock group abstraction, which is more appropriate for its use case. Signed-off-by: Selvam Sathappan Periakaruppan <speriaka@qti.qualcomm.com>
zelvam95
force-pushed
the
feature/plat-qcom-lemans-fuseprov-enablement
branch
from
b4bf594 to
bcdfd27
Compare
Add QFPROM driver support for Lemans platform with 37 fuse regions including security keys, anti-rollback counters, OEM configuration, and calibration data. Add Lemans-specific clock driver header with QFPROM clock register definitions (GCC_SEC_CTRL_CFG_RCGR, GCC_SEC_CTRL_CMD_RCGR). Move platform-specific fuse region enums from common header to target-specific headers to allow per-platform customization. Implement conditional MX voltage rail workaround using CFG_QFPROM_MX_RAIL_WA configuration flag. This workaround is required for Kodiak platform but not needed for Lemans. Signed-off-by: Selvam Sathappan Periakaruppan <speriaka@qti.qualcomm.com>
Enable QFPROM Fuse Provisioning support for Lemans platform with required driver dependencies (CMD_DB, RPMH, QFPROM, CLK). Move common platform definitions to shared section and organize platform-specific definitions (GCC_BASE) into respective platform sections. Signed-off-by: Selvam Sathappan Periakaruppan <speriaka@qti.qualcomm.com>
zelvam95
force-pushed
the
feature/plat-qcom-lemans-fuseprov-enablement
branch
from
bcdfd27 to
c36e3e9
Compare
4 participants
This series enables QFPROM-based fuse provisioning support for the
Qualcomm Lemans platform in OP-TEE.
The implementation builds on the existing Qualcomm fuse provisioning
framework and adds only the required Lemans-specific platform glue to
support secure fuse programming flows. No changes are made to the core
fuse provisioning logic.
The series includes:
The implementation maintains the same conditional compilation approach
as Kodiak, with CFG_QCOM_QFPROM_FUSEPROV defaulting to 'y' for secure
builds and 'n' for insecure builds. Actual fuse programming requires
explicit enablement of CFG_QFPROM_PROGRAMMING as a safety measure.
No functional impact on existing platforms.
Tested on: Lemans platform (secure build)
Dependencies: Requires CMD_DB, RPMH_CLIENT, and QFPROM base drivers