Decoupling sample-apps & camera-service#1892
Closed
shanmaju wants to merge 4 commits intoqualcomm-linux:masterfrom
Closed
Decoupling sample-apps & camera-service#1892shanmaju wants to merge 4 commits intoqualcomm-linux:masterfrom
shanmaju wants to merge 4 commits intoqualcomm-linux:masterfrom
Conversation
Add new PACKAGECONFIG options to align with source changes and improve decoupling of plugins. Upgrade tag from 0.1.0 to 0.1.1 - Refactored build system to decouple base and proprietary plugins and fix strict build issues. - Fixed stability issues including crashes, memory leaks, buffer lifetime, and shutdown/reconfig bugs. - Improved GStreamer pipeline correctness (buffer handling, GAP handling, framerate negotiation). - Added or extended format and capability support (e.g. GRAY8, JPEG, copy‑frame encoding, UAC2). - Enhanced metadata handling and AI/vision pipelines; updated sample-apps and removed deprecated options. Signed-off-by: Tushar Patra Jamula <tjamula@qti.qualcomm.com>
…ackages Restructure gst-plugins-imsdk recipes to enable clean separation between open-source and proprietary plugins, avoiding unintended coupling during OSS-only builds. This refactoring enables: - Building base libraries once, reused by both OSS and proprietary recipes - Clean image composition (qcom-multimedia-image vs qcom-multimedia-proprietary-image) - Clear separation of OSS vs proprietary dependencies Signed-off-by: Tushar Patra Jamula <tjamula@qti.qualcomm.com>
This reverts commit d58b0ce. The workaround is no longer needed since base packages are now built independently. Signed-off-by: Tushar Patra Jamula <tjamula@qti.qualcomm.com>
Signed-off-by: shanmaju <shanmaju@qti.qualcomm.com>
shanmaju
requested review from
anujm1,
koenkooi,
lumag,
ndechesne,
ricardosalveti,
sbanerjee-quic and
vkraleti
as code owners
| @@ -1 +1 @@ | |||
| PACKAGECONFIG:append = " ml messaging qmmfsrc redissink sample-apps" | |||
| PACKAGECONFIG:append = " camera-base ml messaging qmmfsrc redissink sample-apps" | |||
Contributor
There was a problem hiding this comment.
Explain this change in your commit message.
| COMPATIBLE_MACHINE:aarch64 = "(.*)" | ||
|
|
||
| PACKAGECONFIG ??= "sw tools videoproc" | ||
| PACKAGECONFIG ??= "base qairt smartvencbin sw tools videoproc" |
Contributor
There was a problem hiding this comment.
Explain the packageconfig changes in the commit message as well.
| @@ -1,911 +0,0 @@ | |||
| From 0b9ecc606a9b94b0306c5b3d4f29498ca419751d Mon Sep 17 00:00:00 2001 | |||
Contributor
There was a problem hiding this comment.
Shouldn't this removal be squashed with the previous change?
| PACKAGECONFIG[redissink] = "-DENABLE_GST_PLUGIN_REDISSINK=1, -DENABLE_GST_PLUGIN_REDISSINK=0, hiredis" | ||
| PACKAGECONFIG[sample-apps] = "-DENABLE_GST_SAMPLE_APPS=1, -DENABLE_GST_SAMPLE_APPS=0, opencv cairo json-glib camera-service" | ||
| PACKAGECONFIG[sample-apps] = "-DENABLE_GST_SAMPLE_APPS=1, -DENABLE_GST_SAMPLE_APPS=0, opencv cairo json-glib" | ||
| PACKAGECONFIG[sample-apps-overlay] = "-DENABLE_GST_SAMPLE_APPS_OVERLAY=1, -DENABLE_GST_SAMPLE_APPS_OVERLAY=0, opencv cairo json-glib camera-service" |
Contributor
There was a problem hiding this comment.
This should be part of the previous main commit, and explain the changes in the commit message as well.
Contributor
|
The commit summary
isn't in line with our commit policy, it needs to look similar to this:
|
Author
|
changing this pr completely with latest change will raise new PR request to avoid confusion |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.