Skip to content

CAMX: Add static lib as part of tarball#1875

Open
gkhose-qipl wants to merge 4 commits intoqualcomm-linux:masterfrom
gkhose-qipl:camx_downstream
Open

CAMX: Add static lib as part of tarball#1875
gkhose-qipl wants to merge 4 commits intoqualcomm-linux:masterfrom
gkhose-qipl:camx_downstream

Conversation

@gkhose-qipl
Copy link
Copy Markdown
Contributor

@gkhose-qipl gkhose-qipl commented Apr 4, 2026

Include the static library (.a) in the generated tarball for consumers requiring static linking.

@anujm1
Copy link
Copy Markdown
Contributor

anujm1 commented Apr 4, 2026

Include the static library (.a) in the generated tarball for consumers
requiring static linking.
Move linker flags into CMake and drop recipe EXTRA_OECMAKE linker flags.
Install the library directly to the correct path via CMake instead of
moving it post-install in the recipe.

I didn't understand. Which EXTRA_OECMAKE? What is this describing?

@gkhose-qipl
Copy link
Copy Markdown
Contributor Author

Include the static library (.a) in the generated tarball for consumers
requiring static linking.
Move linker flags into CMake and drop recipe EXTRA_OECMAKE linker flags.
Install the library directly to the correct path via CMake instead of
moving it post-install in the recipe.

I didn't understand. Which EXTRA_OECMAKE? What is this describing?

The flags listed below were previously used in the recipe, but we have now updated the CMake file. The removal was Needed due to one comment on PR. https://github.com/qualcomm-linux/meta-qcom-extras/pull/72
EXTRA_OECMAKE += "
-DCMAKE_EXE_LINKER_FLAGS='-L${STAGING_LIBDIR}/camx/talos'
-DCMAKE_SHARED_LINKER_FLAGS='-L${STAGING_LIBDIR}/camx/talos' \

@anujm1
Copy link
Copy Markdown
Contributor

anujm1 commented Apr 4, 2026

The flags listed below were previously used in the recipe, but we have now updated the CMake file. The removal was Needed due to one comment on PR. qualcomm-linux/meta-qcom-extras#72
EXTRA_OECMAKE += " -DCMAKE_EXE_LINKER_FLAGS='-L${STAGING_LIBDIR}/camx/talos' -DCMAKE_SHARED_LINKER_FLAGS='-L${STAGING_LIBDIR}/camx/talos' \

Thanks. Please reword your commit messages to explain changes being brought in the new version and not in a recipe in extras layer. If new version has fixed cmake files in code so it doesn't require hardcoded absolute paths, please say that.

Copy link
Copy Markdown
Contributor

@lumag lumag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move linker flags into CMake and drop recipe EXTRA_OECMAKE linker flags.
Install the library directly to the correct path via CMake instead of
moving it post-install in the recipe.

Please don't describe non-visible changes. They are of no concern to the users of your tarballs.

@ricardosalveti
Copy link
Copy Markdown
Contributor

Please be specific in your commit message, and only describe the changed behavior which is relevant for consumers of this recipe.

Add headers required for camx compilation.

Signed-off-by: Ganesh Khose <gkhose@qti.qualcomm.com>
Include the static library (.a) in the generated tarball for consumers
requiring static linking.

Signed-off-by: Ganesh Khose <gkhose@qti.qualcomm.com>
Include the static library (.a) in the generated tarball for consumers
requiring static linking.

Signed-off-by: Ganesh Khose <gkhose@qti.qualcomm.com>
Include the static library (.a) in the generated tarball for consumers
requiring static linking.

Signed-off-by: Ganesh Khose <gkhose@qti.qualcomm.com>
@gkhose-qipl gkhose-qipl requested a review from lumag April 7, 2026 06:49
@koenkooi
Copy link
Copy Markdown
Contributor

koenkooi commented Apr 7, 2026

Can you change the PR title and description to match your commits? The merge commit will be confusing otherwise.

@gkhose-qipl gkhose-qipl changed the title CAMX: Add static lib and handle install/link flags in CMake CAMX: Add static lib as part of tarball Apr 7, 2026
@gkhose-qipl
Copy link
Copy Markdown
Contributor Author

Can you change the PR title and description to match your commits? The merge commit will be confusing otherwise.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants