CAMX: Add static lib as part of tarball#1875
CAMX: Add static lib as part of tarball#1875gkhose-qipl wants to merge 4 commits intoqualcomm-linux:masterfrom
Conversation
I didn't understand. Which EXTRA_OECMAKE? What is this describing? |
The flags listed below were previously used in the recipe, but we have now updated the CMake file. The removal was Needed due to one comment on PR. https://github.com/qualcomm-linux/meta-qcom-extras/pull/72 |
Thanks. Please reword your commit messages to explain changes being brought in the new version and not in a recipe in extras layer. If new version has fixed cmake files in code so it doesn't require hardcoded absolute paths, please say that. |
a8540ed to
9d93048
Compare
lumag
left a comment
There was a problem hiding this comment.
Move linker flags into CMake and drop recipe EXTRA_OECMAKE linker flags.
Install the library directly to the correct path via CMake instead of
moving it post-install in the recipe.
Please don't describe non-visible changes. They are of no concern to the users of your tarballs.
|
Please be specific in your commit message, and only describe the changed behavior which is relevant for consumers of this recipe. |
Add headers required for camx compilation. Signed-off-by: Ganesh Khose <gkhose@qti.qualcomm.com>
Include the static library (.a) in the generated tarball for consumers requiring static linking. Signed-off-by: Ganesh Khose <gkhose@qti.qualcomm.com>
Include the static library (.a) in the generated tarball for consumers requiring static linking. Signed-off-by: Ganesh Khose <gkhose@qti.qualcomm.com>
Include the static library (.a) in the generated tarball for consumers requiring static linking. Signed-off-by: Ganesh Khose <gkhose@qti.qualcomm.com>
9d93048 to
ca4ebeb
Compare
|
Can you change the PR title and description to match your commits? The merge commit will be confusing otherwise. |
done |
Include the static library (.a) in the generated tarball for consumers requiring static linking.