Skip to content

Conversation

@google-labs-jules
Copy link

This change enhances the fMP4 ingestion pipeline to robustly handle fragmented MP4 (CMAF) streams.

Key improvements:

  • Introduced AtomReader in rs/hang/src/import/atom_reader.rs to manage a BytesMut buffer, allowing correct parsing of atoms split across network chunks (partial reads).
  • Implemented zero-copy extraction of mdat payloads using Bytes::slice / split_to, reducing memory pressure during high-bitrate ingestion.
  • Enforced strict CMAF atom ordering checks (e.g., styp/prft before moof, mdat after moof) with warning logs for violations.
  • Refactored Fmp4 in rs/hang/src/import/fmp4.rs to use AtomReader and handle the parsing loop efficiently.
  • Added comprehensive unit tests for AtomReader covering partial headers, partial bodies, and multiple atoms.

PR created automatically by Jules for task 1425664028654606659 started by @nicolaslevy

@google-labs-jules
Copy link
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant