-
Notifications
You must be signed in to change notification settings - Fork 0
Feat: hls manifest import #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @sebastianpiq, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the application's streaming capabilities by adding support for ingesting HLS (HTTP Live Streaming) manifests. This new feature allows the system to consume HLS streams, parse their playlists, fetch media segments, and then publish them through its own broadcast mechanism. The changes involve introducing a new command-line option for HLS ingestion, implementing dedicated modules for HLS manifest processing, and updating the project's dependencies to support these new functionalities. This enables a broader range of input sources for the streaming platform. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces HLS manifest import functionality, a significant new feature. The changes include adding new dependencies, refactoring the import logic into media and manifest modules, and implementing the HLS fetching and parsing logic. The code is generally well-structured, particularly the new hls.rs file which handles variant selection and segment fetching. The refactoring of the import modules is a good step towards better code organization. I have a few suggestions to improve maintainability and code clarity.
…:Media` for generic tracks
…`ImportManifest` for clarity.
Growing pains.
…t's catalog and remove the `parse` method.
…roadcast's catalog in FMP4 importer.
…tead of creating its own.
…mat to `pub` recipe.
No description provided.