Poc/json parsing

[cotid-qualabs]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @cotid-qualabs, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request lays the groundwork for supporting DASH manifests delivered in JSON format. It enhances the manifest loading process to detect JSON content via HTTP headers and parse it accordingly, while also refining how date properties are processed within the manifest model for greater robustness. This change broadens the compatibility of the system with different manifest delivery mechanisms.

Highlights

• JSON Manifest Parsing: Introduced initial support for parsing DASH manifests that are delivered in JSON format, allowing the system to handle both XML and JSON manifest structures.
• Robust Date Handling: Improved the handling of date-related properties within the DashManifestModel to ensure that values are correctly converted to Date objects, preventing redundant conversions or errors when the input is already a Date.
• HTTP Header Propagation: Modified the HTTP loader to pass response headers to the manifest loader, enabling content type detection for intelligent parsing decisions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces support for JSON-based manifests. The changes allow the manifest loader to parse JSON responses and update the Dash model accordingly. The date handling in DashManifestModel has been made more robust to accommodate date strings from JSON, and the HTTP loader has been updated to pass response headers. The changes look good and align with the goal of the proof-of-concept. I've provided a few suggestions to improve code simplicity, consistency, and error handling.

[gemini-code-assist]

Swallowing the error in this catch block can make debugging difficult. If JSON.parse fails, the error is silently ignored, and the code proceeds to attempt XML parsing on what is likely an invalid JSON string. This will cause a failure later with a misleading error message. It's better to log the JSON parsing error to aid in debugging.

                            try {
                                data = JSON.parse(data);
                            } catch (e) {
                                logger.warn('Failed to parse manifest as JSON, though content-type was application/json.', e);
                            }