Skip to content

fix:update common media library import for cmcd #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cotid-qualabs wants to merge 1 commit into
base: feature/cmcdv2
Choose a base branch
from
Draft

fix:update common media library import for cmcd #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion samples/network-interceptor/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<script class="code" type="text/typescript">

import { CommonMediaRequest, CommonMediaResponse, RequestInterceptor, ResponseInterceptor } from '@svta/common-media-library/request'
import { CmcdObjectType } from '@svta/common-media-library/cmcd'
import { CmcdObjectType } from '@svta/cml-cmcd'
Copy link

@gemini-code-assist gemini-code-assist bot Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change introduces a new dependency @svta/cml-cmcd, but it has not been added to the project's package.json. Without this, the project will fail to install dependencies and build. Please add the new package to the dependencies in package.json.

import * as dashjs from 'dashjs'

declare global {
Expand Down
2 changes: 1 addition & 1 deletion samples/network-interceptor/src/App.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { CommonMediaRequest, CommonMediaResponse, RequestInterceptor, ResponseInterceptor } from '@svta/common-media-library/request'
import { CmcdObjectType } from '@svta/common-media-library/cmcd/CmcdObjectType'
import { CmcdObjectType } from '@svta/cml-cmcd'
import * as dashjs from 'dashjs'

declare global {
Expand Down
2 changes: 1 addition & 1 deletion samples/network-interceptor/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"skipLibCheck": true,

/* Bundler mode */
"moduleResolution": "node",
"moduleResolution": "bundler",
"isolatedModules": true,
"noEmit": false,

Expand Down
8 changes: 1 addition & 7 deletions src/streaming/constants/Constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,7 @@
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
* POSSIBILITY OF SUCH DAMAGE.
*/
import { CmcdPlayerState } from '@svta/common-media-library/cmcd/CmcdPlayerState';
import { CmcdReportingMode } from '@svta/common-media-library/cmcd/CmcdReportingMode';
import { CmcdEventType } from '@svta/common-media-library/cmcd/CmcdEventType';
import { CMCD_DEFAULT_TIME_INTERVAL } from '@svta/common-media-library/cmcd/CMCD_DEFAULT_TIME_INTERVAL';
import { CMCD_PARAM } from '@svta/common-media-library/cmcd/CMCD_PARAM';
import { CMCD_QUERY } from '@svta/common-media-library/cmcd/CMCD_QUERY';
import { CMCD_KEYS } from '@svta/common-media-library/cmcd/CMCD_KEYS';
import { CmcdPlayerState, CmcdReportingMode, CmcdEventType, CMCD_DEFAULT_TIME_INTERVAL, CMCD_PARAM, CMCD_QUERY, CMCD_KEYS } from '@svta/cml-cmcd';

/**
* Constants declaration
Expand Down
5 changes: 1 addition & 4 deletions src/streaming/controllers/CmcdController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,8 @@ import FactoryMaker from '../../core/FactoryMaker.js';
import MediaPlayerEvents from '../MediaPlayerEvents.js';
import Constants from '../../streaming/constants/Constants.js';
import {HTTPRequest} from '../vo/metrics/HTTPRequest.js';
import {CMCD_PARAM} from '@svta/common-media-library/cmcd/CMCD_PARAM';
import {CMCD_PARAM, encodeCmcd, toCmcdHeaders, toCmcdUrl} from '@svta/cml-cmcd';
import Debug from '../../core/Debug.js';
import {encodeCmcd} from '@svta/common-media-library/cmcd/encodeCmcd';
import {toCmcdHeaders} from '@svta/common-media-library/cmcd/toCmcdHeaders';
import {toCmcdUrl} from '@svta/common-media-library/cmcd/toCmcdUrl';

import CmcdReportRequest from '../../streaming/vo/CmcdReportRequest.js';
import Utils from '../../core/Utils.js';
Expand Down
4 changes: 1 addition & 3 deletions src/streaming/models/CmcdModel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,7 @@
* POSSIBILITY OF SUCH DAMAGE.
*/

import {CmcdObjectType} from '@svta/common-media-library/cmcd/CmcdObjectType';
import {CmcdStreamType} from '@svta/common-media-library/cmcd/CmcdStreamType';
import {CmcdStreamingFormat} from '@svta/common-media-library/cmcd/CmcdStreamingFormat';
import {CmcdObjectType, CmcdStreamType, CmcdStreamingFormat} from '@svta/cml-cmcd';
import {HTTPRequest} from '../vo/metrics/HTTPRequest.js';
import MediaPlayerEvents from '../MediaPlayerEvents.js';
import Utils from '../../core/Utils.js';
Expand Down
2 changes: 1 addition & 1 deletion test/unit/test/streaming/streaming.controllers.CmcdController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import DashMetricsMock from '../../mocks/DashMetricsMock.js';
import PlaybackControllerMock from '../../mocks/PlaybackControllerMock.js';
import ThroughputControllerMock from '../../mocks/ThroughputControllerMock.js';
import ServiceDescriptionControllerMock from '../../mocks/ServiceDescriptionControllerMock.js';
import {decodeCmcd} from '@svta/common-media-library/cmcd/decodeCmcd';
import {decodeCmcd} from '@svta/cml-cmcd';
import StreamMock from '../../mocks/StreamMock.js';
import {expect} from 'chai';
import sinon from 'sinon';
Expand Down
Loading