Push up minimum macOS version to 10.15 because of Swift Concurrency support #616
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR updates the minimum macOS deployment target from 10.13 to 10.15 in Package.swift to resolve build failures caused by Swift Concurrency features used in the NoCodes library. Swift Concurrency (async/await) requires macOS 10.15 or later, and without this change, the SDK cannot build when targeting macOS 10.13.
Key Changes
- Updated minimum macOS version from 10.13 to 10.15 in Package.swift platform requirements
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Qonversion SDK v6 fails to build while targeting macOS 10.13 because of Swift Concurrency used in the NoCodes library that requires 10.15 at least. This breaks applications relying on it even if they target a more recent macOS version because the package itself can't build.
This may be a good argument to split the NoCodes into its own sub library but in the meantime this simple patch allows to use the library on macOS again.