Skip to content

Conversation

@hefniraera
Copy link
Collaborator

Fixes #7763

Goal:

Ticket(s): #

  • Backport to LTR documentation is requested

Copy link
Collaborator

@selmaVH1 selmaVH1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than two comments I added, this LGTM..

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong opinion, can we provide schema in this screenshot?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a screenshot for importing to gpkg; the schema label should have been deactivated also (will be fixed in qgis/QGIS#64089)

Comment on lines +114 to +115
You can import layer or file into your database. Here are the parameters you can set
for the import process:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make a reference to this section ?

- |checkbox| :guilabel:`Do not promote to multi-part`: Geometries will be imported as single-part geometries.
- |checkbox| :guilabel:`Convert field names to lower case`: All field names will be converted to lower case.
- |checkbox| :guilabel:`Create spatial index`: A spatial index will be created on the geometry column after import.
- |checkbox| :guilabel:`Comment`: Add comments to the table and columns based on the source layer's metadata. You can also add or edit comments manually.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand. Existing comments in source layer are made available in this field (before you could edit)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to import a layer that has no comment. I was expecting that behavior but after testing it today using layer with existing comment apparently it doesnt work that way (or bug?), we can only add it not edit the existing. It's giving me idea to file a feature request. So that when we try to import vector layer from canvas, it will show us existing comment that is editable. @DelazJ

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is implemented, but for PostGIS (see qgis/QGIS#60875 unless I misunderstand)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that’s correct. As far as I know, table comments are supported only for PostGIS. However, editing existing comments only works when the layer is imported by dragging it from the Layer Panel into the Browser Panel. The same does not work when importing through DB Manager, existing comments are not detected or shown there. 🤔 @DelazJ

* :guilabel:`Options`: Here are some options for the import process:

- |checkbox| :guilabel:`Primary key`: Provide naming for the primary key field.
By default, it is named ``id``.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(need to check but) does this not default to gid for PostgreSQL?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

id on my end

@DelazJ DelazJ added the backport release_3.44 On merge create a backported pull request to 3.44 label Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport release_3.44 On merge create a backported pull request to 3.44

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DB Manager: missing description of "Import Layer/File…" and "Export to File…" dialogs.

3 participants