-
-
Notifications
You must be signed in to change notification settings - Fork 884
Detailed description for import/export dialog DB manager #10482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
selmaVH1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than two comments I added, this LGTM..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No strong opinion, can we provide schema in this screenshot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a screenshot for importing to gpkg; the schema label should have been deactivated also (will be fixed in qgis/QGIS#64089)
| You can import layer or file into your database. Here are the parameters you can set | ||
| for the import process: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make a reference to this section ?
| - |checkbox| :guilabel:`Do not promote to multi-part`: Geometries will be imported as single-part geometries. | ||
| - |checkbox| :guilabel:`Convert field names to lower case`: All field names will be converted to lower case. | ||
| - |checkbox| :guilabel:`Create spatial index`: A spatial index will be created on the geometry column after import. | ||
| - |checkbox| :guilabel:`Comment`: Add comments to the table and columns based on the source layer's metadata. You can also add or edit comments manually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand. Existing comments in source layer are made available in this field (before you could edit)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to import a layer that has no comment. I was expecting that behavior but after testing it today using layer with existing comment apparently it doesnt work that way (or bug?), we can only add it not edit the existing. It's giving me idea to file a feature request. So that when we try to import vector layer from canvas, it will show us existing comment that is editable. @DelazJ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is implemented, but for PostGIS (see qgis/QGIS#60875 unless I misunderstand)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that’s correct. As far as I know, table comments are supported only for PostGIS. However, editing existing comments only works when the layer is imported by dragging it from the Layer Panel into the Browser Panel. The same does not work when importing through DB Manager, existing comments are not detected or shown there. 🤔 @DelazJ
| * :guilabel:`Options`: Here are some options for the import process: | ||
|
|
||
| - |checkbox| :guilabel:`Primary key`: Provide naming for the primary key field. | ||
| By default, it is named ``id``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(need to check but) does this not default to gid for PostgreSQL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
id on my end
Fixes #7763
Goal:
Ticket(s): #