Deduplicate check to reduce binary size#5474
Open
spcyppt wants to merge 1 commit intopytorch:mainfrom
Open
Conversation
Summary: X-link: facebookresearch/FBGEMM#2447 # TLDR; The fix wraps the `TORCH_CHECK` call in a `C10_NOINLINE` helper function (`check_fp8_params`), so the exception-throwing code exists only once in the binary. Call sites are reduced to a simple function call, to reduce binary size. This keeps the binary within the size limit while preserving runtime assertion checking. Differential Revision: D96034242
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/2447
TLDR;
The fix wraps the
TORCH_CHECKcall in aC10_NOINLINEhelper function(
check_fp8_params), so the exception-throwing code exists only once in thebinary. Call sites are reduced to a simple function call, to reduce binary size.
This keeps the binary within the size limit while preserving runtime assertion
checking.
Differential Revision: D96034242