Skip to content

Add pinned dev version of ast_serialize to CI#20836

Open
ilevkivskyi wants to merge 18 commits intopython:masterfrom
ilevkivskyi:add-maturin-temp
Open

Add pinned dev version of ast_serialize to CI#20836
ilevkivskyi wants to merge 18 commits intopython:masterfrom
ilevkivskyi:add-maturin-temp

Conversation

@ilevkivskyi
Copy link
Member

I would propose to merge new-parser in master soon, so that we can parallelize fixing remaining failing tests. This is a preliminary step to check if we can use pinned ast_seriaize in CI.

cc @JukkaL

@JukkaL
Copy link
Collaborator

JukkaL commented Feb 17, 2026

I started preparing the new parser branch for merging, I hope to create a PR later this week.

@ilevkivskyi
Copy link
Member Author

@JukkaL Do you need this CI setup? It looks it is finally working now. This now installs a pinned version of ast_serialize on all Ubuntu workers. I guess you can use this to actually run a selection of tests using the new parser.

@github-actions

This comment has been minimized.

@JukkaL
Copy link
Collaborator

JukkaL commented Feb 17, 2026

Without this the new parser tests would have to be run manually, so this could be quite helpful, but I need to think more about this.

@github-actions

This comment has been minimized.

@ilevkivskyi
Copy link
Member Author

@JukkaL

Without this the new parser tests would have to be run manually, so this could be quite helpful, but I need to think more about this.

OK, you can take this as building block and adjust as needed. For example run a dedicated job for new parser. Btw for now I am skipping free-threaded build as it requires extra configuration (we can still build the wheel when setting up proper CI in ast_serialize).

@github-actions

This comment has been minimized.

@ilevkivskyi
Copy link
Member Author

@JukkaL Now this PR makes parallel tests run with native parser (I temporarily skip parallel tests on Windows). This will:

  • Prevent accidental regressions in native parser
  • Allow me to start working on making parallel checking native-parser-only.

In parallel we can gradually re-enable remaining ~50 skipped tests. (FWIW I don't think there is anything essential there, mostly different error messages, and some rare edge cases.)

If you don't have objections, I will merge this tomorrow.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants