GH-145247: Implement _PyTuple_FromPair#145325
Open
sergey-miryanov wants to merge 10 commits intopython:mainfrom
Open
GH-145247: Implement _PyTuple_FromPair#145325sergey-miryanov wants to merge 10 commits intopython:mainfrom
sergey-miryanov wants to merge 10 commits intopython:mainfrom
Conversation
eendebakpt
reviewed
Feb 28, 2026
Contributor
eendebakpt
left a comment
eendebakpt
left a comment
There was a problem hiding this comment.
To minor comments on the test, but overall this looks good!
Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
eendebakpt
reviewed
Mar 1, 2026
vstinner
reviewed
Mar 4, 2026
Co-authored-by: Victor Stinner <vstinner@python.org> Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
Contributor
Author
|
@eendebakpt @vstinner Thanks for review! Could you please take another look? |
sergey-miryanov
requested review from
a team,
AA-Turner,
emmatyping and
erlend-aasland
as code owners
johnslavik
reviewed
Mar 5, 2026
Member
johnslavik
left a comment
johnslavik
left a comment
There was a problem hiding this comment.
I'll try to take a closer look soon.
Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyTuple_FromPair#145247