fix(env): honor detected shell in env activate output#10716
Open
LouisLau-art wants to merge 1 commit intopython-poetry:mainfrom
Open
fix(env): honor detected shell in env activate output#10716LouisLau-art wants to merge 1 commit intopython-poetry:mainfrom
LouisLau-art wants to merge 1 commit intopython-poetry:mainfrom
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts env activation command generation to respect the detected shell rather than the host OS, ensuring POSIX-style shell prefixes are used for bash even on Windows, and adds a regression test for this behavior. Class diagram for updated env activation command generationclassDiagram
class EnvActivateCommand {
+_get_activate_command(env, shell) str
+_quote(path, shell) str
}
class Env {
+bin_dir
}
class PathLike {
+exists() bool
+__truediv__(other) PathLike
}
EnvActivateCommand ..> Env : uses
Env "1" --> "1" PathLike : bin_dir
note for EnvActivateCommand "_get_activate_command now always builds 'command quoted' and applies strip so behavior depends on shell-specific quoting rather than host OS"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
env activatedecide output format by detected shell instead of host OSsource ...) for POSIX shells even on Windowscmd,powershell, andpwshFixes #10395.
Testing
pytest -q -o addopts='' tests/console/commands/env/test_activate.py