Fix RaisesGroup calling check() on contained exceptions instead of Ex…#14358
Closed
kelliott1 wants to merge 4 commits intopytest-dev:mainfrom
Closed
Fix RaisesGroup calling check() on contained exceptions instead of Ex…#14358kelliott1 wants to merge 4 commits intopytest-dev:mainfrom
kelliott1 wants to merge 4 commits intopytest-dev:mainfrom
Conversation
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix RaisesGroup incorrectly calling check() on contained exceptions.
Files changed:
raises.py
raises_group.py (tests)
Problem:
RaisesGroup(..., check=...) invoked the check callback twice:
- once with the ExceptionGroup (correct)
- once with a contained exception (incorrect)
This could cause unexpected errors (e.g. AttributeError) and violated the documented behavior.
Fix:
Removed the extra invocation of check() on contained exceptions.
Ensured check() is only called with the ExceptionGroup.
Adjusted suggestion logic to avoid reusing the callback.
Tests:
Updated test_check() expectations.
Added regression test to ensure check() is called once and only with the group.
Result:
check() now behaves as documented and no longer receives contained exceptions.