Fix capture asymmetry in suspend_global_capture(in_=True)#14356
Open
FazeelUsmani wants to merge 4 commits intopytest-dev:mainfrom
Open
Fix capture asymmetry in suspend_global_capture(in_=True)#14356FazeelUsmani wants to merge 4 commits intopytest-dev:mainfrom
suspend_global_capture(in_=True)#14356FazeelUsmani wants to merge 4 commits intopytest-dev:mainfrom
Conversation
psf-chronographer
bot
added
the
bot:chronographer:provided
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13322.
If a plugin hook suspends out/err and then calls
suspend_global_capture(in_=True)(e.g. to read input), the matchingresume_global_capture()was incorrectly re-enabling out/err even though the caller had them suspended. Fix is to remember what was started before the nested suspend and only resume those.Includes a
pytesterregression that runs the flow from apytest_terminal_summaryhook and checks that the print after the resume reaches stdout before the1 passedline. Before the fix it only shows up at teardown, after the summary.