-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
ci: gh release create needs a checkout
#13891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Not sure why, but it failed without one in CI: ``` $ gh release create --notes-file gh-release-notes.md --verify-tag "$VERSION" dist/* failed to run git: fatal: not a git repository (or any of the parent directories): .git ```
Backport to 9.0.x: 💚 backport PR created✅ Backport PR branch: Backported as #13899 🤖 @patchback |
ci: `gh release create` needs a checkout (cherry picked from commit 4b73dca)
|
@bluetech was it in CI or locally? If you have a link to the log, I could take a look. |
|
Ah, never mind. I didn't look into the patch before commenting 🤦♂️ |
|
@webknjaz If you know why it needs a git checkout I'd be interested to know. I assumed it would work just at the github API level. |
|
I bet it tries to infer the current repo to interact with from that. I think you should be able to pass the repository via CLI or env vars instead. |
|
Hmm yes that makes sense. I somehow imagined it can figure it out from context but probably not. So maybe with |
|
I'm pretty sure I saw Also, https://cli.github.com/manual/gh_api says this:
|
|
https://cli.github.com/manual/gh_release_create says it supports |
Not sure why, but it failed without one in CI: