Open
Conversation
Member
Author
|
This is just an initial proposal for the fix. @lawrence-danna-apple can you clarify on the Apple policy? Is the version only omitted starting from 12 and onwards? Is it always omitted, or should we keep the |
FFY00
force-pushed
the
allow-mac-version-only-major
branch
2 times, most recently
from
d125185 to
0a9ef80
Compare
FFY00
force-pushed
the
allow-mac-version-only-major
branch
3 times, most recently
from
e1ee4b8 to
0d4dcaf
Compare
Signed-off-by: Filipe Laíns <lains@riseup.net>
FFY00
force-pushed
the
allow-mac-version-only-major
branch
from
0d4dcaf to
8405a84
Compare
uranusjr
approved these changes
Jul 22, 2022
rgommers
reviewed
Jul 22, 2022
| yield "macosx_{major}_{binary_format}".format( | ||
| major=major_version, binary_format=binary_format | ||
| ) | ||
| # Mac OS 11 and 12 seem to omit the minor version, we will keep |
There was a problem hiding this comment.
This comment is going to be confusing, see #578 (comment)
Member
brettcannon
requested changes
Nov 25, 2022
Member
brettcannon
left a comment
brettcannon
left a comment
There was a problem hiding this comment.
Minor-free tags should come after all minor-including tags, not replace them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #578