Skip to content

msvc compiler: Re-sort sources to compile Message Compiler files (.mc) first#370

Open
Avasam wants to merge 1 commit intopypa:mainfrom
Avasam:Resort-sources-to-have-.mc-first
Open

msvc compiler: Re-sort sources to compile Message Compiler files (.mc) first#370
Avasam wants to merge 1 commit intopypa:mainfrom
Avasam:Resort-sources-to-have-.mc-first

Conversation

@Avasam
Copy link
Contributor

@Avasam Avasam commented May 6, 2025 •
edited
Loading

Ensures that Message Compiler files come first.

Closes pypa/setuptools#4986

@Avasam Avasam changed the title msvc compiler: Resort sources to have .mc first msvc compiler: Re-sort sources to have Message Compiler files (.mc) first May 7, 2025
@Avasam Avasam changed the title msvc compiler: Re-sort sources to have Message Compiler files (.mc) first msvc compiler: Re-sort sources to compile Message Compiler files (.mc) first May 7, 2025
@Avasam Avasam force-pushed the Resort-sources-to-have-.mc-first branch from 034b27f to 8ef7f0a Compare May 7, 2025 00:03
@Avasam
Copy link
Contributor Author

Avasam commented May 7, 2025

I guess unfortunately coverage is gonna have to go down since this is only tested on Windows.

@Avasam Avasam force-pushed the Resort-sources-to-have-.mc-first branch from 8ef7f0a to d991fd4 Compare May 7, 2025 01:29
@Avasam Avasam force-pushed the Resort-sources-to-have-.mc-first branch 2 times, most recently from a9d42b6 to 7fe2c33 Compare May 16, 2025 00:33
@Avasam Avasam force-pushed the Resort-sources-to-have-.mc-first branch from 7fe2c33 to 81d6329 Compare May 16, 2025 15:12
@Avasam Avasam mentioned this pull request Jun 17, 2025
Open
@Avasam
Copy link
Contributor Author

Avasam commented Sep 26, 2025

Copying @raedrizqie 's comment here as well as my answer:

pypa/setuptools#4986 (comment)

Thanks @Avasam for this PR. Could you please made the sorting in build_ext.build_extension, so that MinGW could also benefit from it?

pypa/setuptools#4986 (comment)

I tried to only apply the change to compilers that would be relevant to building MC files. I'm not too familiar with MinGW, but I don't mind adding the sorting to both. Or directly in the build_ext command if the distutils maintainers think it would belong there. Just waiting on some answer on the PR itself by maintainers.

@Avasam Avasam mentioned this pull request Dec 9, 2025
Merged
@Avasam
Copy link
Contributor Author

Avasam commented Feb 16, 2026

@abravalheri @jaraco Do you have a preference on whether this should be duplicated in the mingw compiler, or if it should go in build_ext ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FR] When sorting sources, move Message Compiler (.mc) files first

1 participant

@Avasam