Skip to content

Conversation

@samwaseda
Copy link
Member

Forgot to append it to #61

@samwaseda samwaseda requested a review from Copilot December 31, 2025 23:23
@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch pyiron/flowrep/asdict

@codecov
Copy link

codecov bot commented Dec 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.07%. Comparing base (f788b97) to head (1a73d7c).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
+ Coverage   96.05%   96.07%   +0.01%     
==========================================
  Files           3        3              
  Lines         659      662       +3     
==========================================
+ Hits          633      636       +3     
  Misses         26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for dataclass instances as input values in workflow nodes by converting them to dictionaries before JSON serialization. The change prevents serialization errors that would occur when hashing workflow nodes containing dataclass values.

  • Imports asdict and is_dataclass from the dataclasses module
  • Adds a conditional check to detect dataclass instances in node input values
  • Converts dataclass instances to dictionaries using asdict() before storing them in the hash dictionary

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@samwaseda samwaseda merged commit 9280635 into main Dec 31, 2025
19 checks passed
@samwaseda samwaseda deleted the asdict branch December 31, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants