Open
Conversation
Collaborator
Author
|
It would maybe be nice to not wrap 3 elements? But I guess that is debatable. |
10 tasks
Collaborator
Author
|
v2 now takes into account the figsize if specified. |
Collaborator
Author
|
v3 now supports aspect as well. 
|
kkollsga
added a commit
to kkollsga/xarray
that referenced
this pull request
Mar 29, 2026
Extend facetgrid_figsize to accept a (width, height) tuple in addition to "computed" and "rcparams". Also move figsize resolution before grid shape computation for better composition with col_wrap="auto" (pydata#11266). Co-authored-by: Claude <noreply@anthropic.com>
Illviljan
approved these changes
Mar 29, 2026
Contributor
Illviljan
left a comment
Illviljan
left a comment
There was a problem hiding this comment.
Thanks, this looks very nice!
In V1 I had some thoughts of maybe calling the option "square" since it always strived towards that. But now it's clever enough for the generic "auto" I think.
Comment on lines
-204
to
-205
| if row: | ||
| ncol = 1 |
Contributor
There was a problem hiding this comment.
row was not needed due to single_group=True. (either row or col is defined)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
whats-new.rstI often ended up writing this logic myself, better to make it as part of xarray.
While implementing it I noticed this comment:
That should be covered now :)