App: Drop hacks that preserved docs scroll.#2368
Open
laurensvalk wants to merge 1 commit intomasterfrom
Open
Conversation
The iframe automatically scrolled to 0 when CSS `display: none` is set, so we had several workarounds. Hide it instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The iframe automatically scrolled to 0 when CSS
display: noneis set, so we had several workarounds to keep track of scrolling.We can keep it in the DOM and hide it instead. This lets us get rid of the workarounds, but keep the position if you open the docs again.
On a related note, I wonder if we really need the active page to persist across a full reload with
app/hooks.ts.Using session storage, mirroring to local storage, and then manage outdated links all seems relatively complicated for something that isn't necessarily practical. The next day, I'd personally rather start from the home page. It also makes things a bit more complicated when navigating to a particular page from an interaction: pybricks/support#1515
Feel free to 👍 or 👎 this suggestion @dlech, otherwise I'd be happy to submit this in the next one.