Updated Dockerfile

[acald-creator]

Dockerfile is still WIP for certain lines that may need to be reverted upon discussion.

Checklist

• [ x ] I have read the contributing guidelines
• [ x ] I have read the documentation
• [ x ] I have included a descriptive Pull Request title
• [ x ] I have included a Pull Request description of my changes
• [ x ] I have included tests where/when required (see contributing guidelines)
• [ x ] I have included documentation modifications/additions where/when required (see contributing guidelines)

I have updated the Dockerfile with the following items

1. Changed node:16-alpine to node:17-alpine
2. Grouped ENV one-line
3. Write out the directory /usr/src/app/ instead of storing it in ENV
4. Removed cd $WORKDIR && npm install and just use npm install. @todo may need to add WORKDIR to indicate /usr/src/app as the starting point, but Docker image seemed to have built fine.

[binarymist]

Thanks for this :-)

Combining ENVs might make the build time slightly shorter but it doesn't actually reduce the number of image layers.

Removing the WORKDIR environment variable also arguably creates unnecessary repetition.

Did you consider multi-stage builds?

Did you consider combining more commands?

Did you consider creating Dockerfile from scratch (https://hub.docker.com/_/scratch)?

There are many techniques for creating small Dockerfiles, which ones did you consider and why have you decided not to use them?

Thanks.

[binarymist]

Any progress @acald-creator?