sending another pull request #3879
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am submitting another pull request, I believe there is a lot of confusion mostly coming from the variable names.. to be clear puppyinstaller works with efi in frugal mode.. the "fullinstall" button launches the puppyinstaller to do a frugal install.. full install is locked some how .. read the begging of the script. any ways I have fixed the puppyinstaller and can confirm it now works with efi, bdrv, as well as non-bdrv pups .. please read the commits. I also still left the grub for dos check disabled, read comment to understand why I believe that needs to be done, but if nothing else please implement the other changes...
Author
|
please read .. |
Contributor
|
I don't see any fixes in puppyinstaller in this PR. Are you sure this is the right branch? https://github.com/puppylinux-woof-CE/woof-CE/pull/3879/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am submitting another pull request, I believe there is a lot of confusion mostly coming from the variable names.. to be clear puppyinstaller works with efi in frugal mode.. the "fullinstall" button launches the puppyinstaller to do a frugal install.. full install is locked some how .. read the begging of the script. any ways I have fixed the puppyinstaller and can confirm it now works with efi, bdrv, as well as non-bdrv pups .. please read the commits. I also still left the grub for dos check disabled, read comment to understand why I believe that needs to be done, but if nothing else please implement the other changes...