fix: clamp cursor column during rendering to prevent display at invalid positions#1414
Open
asiloisad wants to merge 1 commit intopulsar-edit:masterfrom
Open
fix: clamp cursor column during rendering to prevent display at invalid positions#1414asiloisad wants to merge 1 commit intopulsar-edit:masterfrom
asiloisad wants to merge 1 commit intopulsar-edit:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I occasionally observe the cursor appearing at an indented position on empty lines (e.g., cursor visually at column 4 when the line has 0 characters). The issue:
Investigation
clipPositionproperly clamps to line lengthtranslateScreenPositionandconstrainScreenPositioncorrectly clip positionssetScreenPositioncorrectly delegates to display markeraddCursorDecorationToMeasureusesmarker.getScreenRange()which occasionally returns stale/unclipped position due to timingThe root cause appears to be a race condition where the display layer's spatial index or screen line data hasn't fully synchronized when cursor decoration rendering queries the marker's screen position.
Solution
Add defensive column clamping at the rendering level in
addCursorDecorationToMeasure().This reuses the lineLengthForScreenRow() call that was already being made, so there's no performance impact.