[spell-check] Rewrite/reformat for ease of understanding…#1311
Open
savetheclocktower wants to merge 1 commit intomasterfrom
Open
[spell-check] Rewrite/reformat for ease of understanding…#1311savetheclocktower wants to merge 1 commit intomasterfrom
savetheclocktower wants to merge 1 commit intomasterfrom
Conversation
…with a couple of bug fixes along the way.
Contributor
Author
|
(I mean, the tests passed on my machine, so…) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…with a couple of bug fixes along the way.
Part of this is to at least give folks who suffer from #1287 something to test out in the unlikely event that this fixes it.
But the
spell-checkpackage is full of barely decaffeinated code that was begging for simplification. I'm also quite certain that I caught one transcription bug when attaching subscriptions, and maybe that's the cause of the trouble?But at any rate, the tests still pass and the code is more readable.