-
-
Notifications
You must be signed in to change notification settings - Fork 7
Update Frontend Site to match new Web Presence #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@savetheclocktower Curious |
|
OK, got it working. I'll still take a pass on this and see if I can spruce some things up. |
|
@savetheclocktower Great catch on missing the error pages, I'll add those in. |
|
Random thought: this new site advertises the ability to search for services while specifying the service version (i.e., “give me all If we can't easily address this (and I doubt we can) then we should probably hide the search-by-service-version functionality for now. |
|
OK, I opened a PR against this branch in #145. |
|
@savetheclocktower To the point of having the service version search be understanding of semver, that's not yet currently possible. But is a great idea, that I will add as a feature request of the backend, since that would be really handy to have |
|
@savetheclocktower Think we are now good to merge this one? |
|
Would that automatically upgrade https://packages.pulsar-edit.dev/ to the new look and feel? I might spend a half-hour or so tonight just doing some stress-testing, but I think this could land very soon. |
|
@savetheclocktower Once merged I'd still need to deploy the new revision to GCP, but I'd very likely do that immediately and unless we wanted to be fancy with AB testing it'd rollout right away EDIT: So stress testing prior is not a bad idea at all and give us some time trying to break things, especially on mobile |
|
@confused-Techie, does the Install button work for you at all on the site? If not, we should hold off until we get it working. It's not doing anything for me. |
|
@savetheclocktower It looks like I forgot the link on the package listing page, but check if the install button works on a single package page, and I'll add the link |
|
Yeah, it works on single package pages. 👍 |
Fix is in for all pages btw, so we should be good |
|
@savetheclocktower Thanks for the approval! I'll go ahead and merge this one! |



The major focus of this PR is to update the frontend site to match with our new web style and presence. Taking cues from how we handle our website everywhere else to get this one updated.
That does mean we are now removing support for the different themes that existed here unfortunately.
Additionally in this PR:
/statuspage, instead using the Server headerThere's still several places I hope to work more on the site, but those are out of the scope of this original PR