Explicitly include cstdint to make GCC happy#9
Merged
Conversation
DeeDeeG
approved these changes
Jan 4, 2026
Member
DeeDeeG
left a comment
There was a problem hiding this comment.
LGTM!
From testing, I can confirm the problem exists as described in #8, and I can confirm this change fixes the issue in question. 👍
Testing notes:
- I set up a Fedora 43 LiveUSB environment
- (Coincidentally already had this set up before I saw this PR!)
- Tried
yarn installin a checkout ofpulsar-edit/pulsar- (Installed various X11 and Wayland-related
-develpackages until their respective "missing header" compilation errors went away (typical when starting from a fresh LiveUSB environment without all these development header packages, unrelated to the present issue/PR) - Confirmed compilation error as described in #8 👍
- (Installed various X11 and Wayland-related
- Modified
pulsar-edit/pulsar'spackage.jsonwhere it specifies@pulsar-edit/fuzzy-native, with a new "version specifier" to test this PR's changes, like so:"@pulsar-edit/fuzzy-native": "https://github.com/pulsar-edit/fuzzy-native/archive/368c8c7b179482f1958ca44e2bcfd8d43e302ab1.tar.gz",
- Did
yarn installagain- This worked,
yarn installcompleted without errors! 👍
- This worked,
Member
|
Thank you @savetheclocktower for giving this fix, and to @leotada for the initial report! We can get it into core Pulsar by tagging a new version of this package, and bumping that in core Pulsar repo. |
Author
|
The bad news is that I think we have to revisit the CI workflow that publishes to NPM (since NPM has made those publishing-related changes for security). The good news is that this is probably just a nice-to-have and not a blocker for the Electron upgrade release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8.