Skip to content

sw: Allow cluster level overwrites of CMake definitions#53

Merged
DiyouS merged 1 commit intopulp-platform:mainfrom
Smephite:feat/generalCmake
Mar 25, 2026
Merged

sw: Allow cluster level overwrites of CMake definitions#53
DiyouS merged 1 commit intopulp-platform:mainfrom
Smephite:feat/generalCmake

Conversation

@Smephite
Copy link
Contributor

@Smephite Smephite commented Dec 9, 2025

This PR introduces more flexibiliy in the CMake compilation flow.

Before, the flow relied on a known set of spatz cluster configuration files.
With the changes introduced, it is possible to set these values also using a CMake definition (e.g., using a CLI parameter).

This allows for more flexibility in software compilation when using it in a (multi-cluster) SoC.

@anga93 anga93 requested review from DiyouS and MaoyuanCai February 3, 2026 11:33
@anga93
Copy link
Member

anga93 commented Feb 3, 2026

Hi @Smephite can you rebase on the current main? Afterwards, we will review it and merge it

Copy link
Collaborator

@DiyouS DiyouS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Navaneeth-KunhiPurayil Can we run the CI check for this PR?

Less hardcoding of Spatz configurations but instead put the burden on higher-level settings.
@DiyouS DiyouS force-pushed the feat/generalCmake branch from ffefd95 to b4c39a0 Compare March 19, 2026 15:04
@DiyouS
Copy link
Collaborator

DiyouS commented Mar 25, 2026

@Navaneeth-KunhiPurayil Ready to merge

Copy link
Contributor

@Navaneeth-KunhiPurayil Navaneeth-KunhiPurayil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DiyouS DiyouS merged commit f1444e7 into pulp-platform:main Mar 25, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants