[LA64_DYNAREC] fix COMISS/UCOMISS flags state handling#3631
Merged
ksco merged 1 commit intoptitSeb:mainfrom Mar 9, 2026
Merged
[LA64_DYNAREC] fix COMISS/UCOMISS flags state handling#3631ksco merged 1 commit intoptitSeb:mainfrom
ksco merged 1 commit intoptitSeb:mainfrom
Conversation
Signed-off-by: Zewei Yang <yangzewei@loongson.cn>
ptitSeb
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason for canceling DF is that using SF_SET_DF in the 0F 2E/2F path of LA64 dynarec causes single-precision SVD results from scipy.linalg to be incorrect. The corresponding double-precision COMISD/UCOMISD (66 0F 2E/2F) uses the immediate flags path (SF_SET), so it does not have the same problem.
Reproduce code:
You will need an x86 Python program and the relevant packages (scipy && numpy) installed.
I suspect that arm64 also has a similar problem.dynarec_arm64_0f.c