fix: Include LICENSE and NOTICE files in wheel distribution #7138
+178
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LICENSE and NOTICE files were referenced in setup.py's package_data
but with the wrong key ("" instead of "requests"). This caused them to
not be included in wheel builds.
Fixed by:
1. Copying LICENSE and NOTICE into src/requests/ directory
2. Updating package_data to use "requests" as the key
This is required by the Apache License which mandates inclusion of the
NOTICE file in distributions.
Fixes psf#7034
Author
|
@clee would you review this PR? |
Contributor
Wrong clee, I’m guessing |
Contributor
Sounds as though you did not actually perform this change yourself or make the contribution in good faith. This is also the wrong change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The LICENSE and NOTICE files were referenced in setup.py's
package_databut with the wrong key (""instead of"requests"). This caused them to not be included in wheel builds.Fixed by:
src/requests/directorypackage_datato use"requests"as the keyThis is a minimal fix that doesn't require migrating to a new build system.
Why this matters
The Apache License requires inclusion of the NOTICE file in distributions. Currently, the wheel distribution is missing this file.
Fixes #7034
Contribution by Gittensor, see my contribution statistics at https://gittensor.io/miners/details?githubId=101010297