Skip to content

fix: handle empty string cookie values correctly #7128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shindonghwi wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

fix: handle empty string cookie values correctly #7128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/requests/cookies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ def _find_no_duplicates(self, name, domain=None, path=None):
# we will eventually return this as long as no cookie conflict
toReturn = cookie.value

if toReturn:
if toReturn is not None:
return toReturn
raise KeyError(f"name={name!r}, domain={domain!r}, path={path!r}")

Expand Down
8 changes: 8 additions & 0 deletions tests/test_requests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1299,6 +1299,14 @@ def test_cookie_as_dict_keeps_len(self):
assert len(d2) == 2
assert len(d3) == 2

def test_cookie_empty_value(self):
"""Empty string cookie values should be retrievable."""
jar = requests.cookies.RequestsCookieJar()
jar.set("empty", "")

assert jar["empty"] == ""
assert jar.get("empty") == ""

def test_cookie_as_dict_keeps_items(self):
key = "some_cookie"
value = "some_value"
Expand Down