Skip to content

fix pgsql test setup and ci #2052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhilinTv merged 2 commits into from
Jun 18, 2025
Merged

fix pgsql test setup and ci #2052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
482dd1f
fix syntax error in pgsql test setup
smhg Jun 18, 2025
33b6208
fix php and symfony version match in pgsql install
smhg Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
postgresql password: $DB_PW

- name: Install PostgreSQL 16
if: matrix.db-type == 'pgsql' && matrix.php-version == '7.4' && matrix.symfony-version == '6-max'
if: matrix.db-type == 'pgsql' && matrix.php-version == '7.4' && matrix.symfony-version == '5-max'
uses: CasperWA/[email protected]
with:
postgresql version: 16
Expand All @@ -61,7 +61,7 @@ jobs:
postgresql password: $DB_PW

- name: Install PostgreSQL min
if: matrix.db-type == 'pgsql' && matrix.php-version == '7.4' && matrix.symfony-version == '6-min'
if: matrix.db-type == 'pgsql' && matrix.php-version == '7.4' && matrix.symfony-version == '5-min'
uses: CasperWA/[email protected]
with:
postgresql version: 9
Expand Down
2 changes: 1 addition & 1 deletion tests/bin/setup.pgsql.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ if [ "$DB_NAME" = "" ]; then
fi

DB_HOSTNAME=${DB_HOSTNAME-127.0.0.1};
DB_PW=${DB_PW-$PGPASSWORD};.0.1};
Copy link
Contributor

@PhilinTv PhilinTv Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, thanks!

DB_PW=${DB_PW-$PGPASSWORD};
DB_PORT=${DB_PORT-5432};

if [ -z "$DB_PW" ]; then
Expand Down