Skip to content

Conversation

@mringler
Copy link
Contributor

Fixes issue in comment.

I have also changed the UuidConverter, so that it handles null values. The initial idea was to be strict with the type, but it is not robust and lead to ugly code, where the null check has to be performed manually every time.

Includes test fix from #1980, otherwise tests would fail.

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.27%. Comparing base (4f36eea) to head (6b29c6d).
⚠️ Report is 70 commits behind head on master.

Files with missing lines Patch % Lines
src/Propel/Generator/Builder/Om/ObjectBuilder.php 90.00% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1981   +/-   ##
=========================================
  Coverage     89.27%   89.27%           
- Complexity     8049     8052    +3     
=========================================
  Files           232      232           
  Lines         24519    24527    +8     
=========================================
+ Hits          21889    21897    +8     
  Misses         2630     2630           
Flag Coverage Δ
5-max 89.27% <93.75%> (+<0.01%) ⬆️
7.4 89.27% <93.75%> (+<0.01%) ⬆️
agnostic 67.47% <68.75%> (+<0.01%) ⬆️
mysql 69.81% <87.50%> (+<0.01%) ⬆️
pgsql 69.92% <87.50%> (+0.08%) ⬆️
sqlite 67.88% <87.50%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mringler mringler force-pushed the bugfix/convert_uuid_in_pk_on_update branch from f5ccdb9 to 6b29c6d Compare September 30, 2023 07:00
@mringler mringler mentioned this pull request Sep 30, 2023
@mringler mringler changed the title convert UUID_BINARY in pk on update Bugfix: convert UUID_BINARY in pk on update Apr 25, 2024
@PhilinTv PhilinTv added this to the 2.0.0 Beta 5 - LTS Release milestone Jun 24, 2025
@PhilinTv PhilinTv added the Bug label Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UUID type support

3 participants