Fix pkgconfig install to respect DESTDIR #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The install script for the pkgconfig file was writing directly to CMAKE_INSTALL_PREFIX without respecting DESTDIR. This broke staged installs used by package managers (dpkg-buildpackage, rpmbuild, etc). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR fixes the pkgconfig file installation to properly respect the DESTDIR environment variable, which is essential for staged installs used by package managers like dpkg-buildpackage and rpmbuild.
Key changes:
- Modified the pkgconfig install script to prepend
DESTDIRto the installation path - Added directory creation before file installation to ensure the target directory exists
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The install script for the pkgconfig file was writing directly to CMAKE_INSTALL_PREFIX without respecting DESTDIR. This broke staged installs used by package managers (dpkg-buildpackage, rpmbuild, etc).
Found while preparing Debian packaging for projectm-eval.