[Code Driven]: #2 – Closure Control Logic Movement and Backward Compatibility#43203
Open
pimpalemahesh wants to merge 6 commits intoproject-chip:masterfrom
Open
[Code Driven]: #2 – Closure Control Logic Movement and Backward Compatibility#43203pimpalemahesh wants to merge 6 commits intoproject-chip:masterfrom
pimpalemahesh wants to merge 6 commits intoproject-chip:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request effectively refactors the Closure Control cluster to a code-driven structure, which is a great improvement for maintainability and testability. The changes are well-organized, with file renames and code movement that align with the new architecture. I've found a critical copy-paste error that would prevent compilation and a minor documentation issue. Once these are addressed, this PR will be in excellent shape.
|
PR #43203: Size comparison from 3ba5c51 to c8485fe Full report (27 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32)
|
pimpalemahesh
force-pushed
the
closure-control/code-movement
branch
from
c8485fe to
dc1ea45
Compare
|
PR #43203: Size comparison from 3ba5c51 to dc1ea45 Full report (27 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the second PR in the migration of the Closure Control cluster to the code-driven structure.
Changes Included
Renamed files to follow the code-driven naming convention:
Moved implementation code into the newly structured files.
Kept the original files to maintain backward compatibility where applicable.
Removed
closure-control-cluster-matter-context.hIts contents were moved intoClosureControlClusterLogic.hsince they are strictly logic-related.This may introduce a minor backward compatibility impact.
However, this MatterContext is currently only used for marking attributes as dirty.
In a follow-up MR,
NotifyAttributeChanged()will be used instead, making the previous approach unnecessary.Related issues
NA
Testing
Successfully built the Closure app locally.
Run tests for closure app
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See: Pull Request Guidelines